Build breakage for CONFIG_PM but no CONFIG_SUSPEND

Kumar Gala galak at kernel.crashing.org
Sat Feb 7 03:26:46 EST 2009


On Feb 6, 2009, at 10:04 AM, Scott Wood wrote:

> On Fri, Feb 06, 2009 at 11:10:27AM +1100, Michael Neuling wrote:
>> I noticed this doing some randconfig testing (.config below).  I have
>> CONFIG_PM but no CONFIG_SUSPEND.  Bug is against mainline.
>>
>> arch/powerpc/sysdev/built-in.o: In function `ipic_suspend':
>> ipic.c:(.text+0x6b34): undefined reference to `fsl_deep_sleep'
>> make[1]: *** [.tmp_vmlinux1] Error 1
>> make: *** [sub-make] Error 2
>>
>> Looks like #ifdef CONFIG_PM in arch/powerpc/sysdev/ipic.c should be
>> CONFIG_SUSPEND.  d49747bdfb2ddebea24d1580da55b79d093d48a9 introduced
>> this.
>>
>> Maybe this fixes it?
>>
>>
>> Fix build when we have CONFIG_PM but no CONFIG_SUSPEND.
>
> ACK.  That was a leftover from before CONFIG_SUSPEND was introduced.

If you send a proper patch I'll apply it and queue it up with some  
other fixes.

- k



More information about the Linuxppc-dev mailing list