[PATCH 2/2] powerpc, ftrace: fix compile error when modules not configured

Steven Rostedt rostedt at goodmis.org
Fri Feb 6 17:27:06 EST 2009


On Fri, 2009-02-06 at 17:23 +1100, Michael Neuling wrote:
> In message <20090206060527.369616736 at goodmis.org> you wrote:
> > From: Steven Rostedt <srostedt at redhat.com>
> > 
> > Michael Neuling reported a compile bug when dynamic ftrace was
> > configured in and modules were not. This was due to the ftrace
> > code referencing module specific structures.
> > 
> > Reported-by: Michael Neuling <mikey at neuling.org>
> > Signed-off-by: Steven Rostedt <srostedt at redhat.com>
> 
> Steve,
> 
> Thanks, fixes the error I was seeing.  

Cool.

> 
> As an aside, is there anyway we can merge some of the code in
> arch/powerpc/kernel/ftrace.c between 32 and 64bit?  There seems to be a
> lot of repeated code in there with only minor changes.

It looks similar, but there's enough differences that I would like to
keep them separate. The code is complex enough and has a lot of subtle
differences between the two archs.

-- Steve




More information about the Linuxppc-dev mailing list