[PATCH -tip tracing/kprobes] PPC: Powerpc port of the kprobe-based event tracer

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Dec 17 18:07:07 EST 2009

On Thu, 2009-12-17 at 13:22 +1100, Michael Neuling wrote:

> > + * The @offset is the offset of the register in struct pt_regs.
> > + * If @offset is bigger than MAX_REG_OFFSET, this returns 0.
> > + */
> > +static inline unsigned long regs_get_register(struct pt_regs *regs,
> > +						unsigned int offset)
> Please put only function definitions in the .h file.  The rest of this
> should be in .c

Not really in that case actually. There are just simple accessors, we
traditionally have them in .h files so they get fully inlined when

I'll have a look at the rest of the patch asap, hopefully tomorrow.


More information about the Linuxppc-dev mailing list