[PATCH] cardbus: Add a fixup hook and fix powerpc

Jesse Barnes jbarnes at virtuousgeek.org
Thu Dec 17 06:23:02 EST 2009

On Wed, 09 Dec 2009 17:52:13 +1100
Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:

> The cardbus code creates PCI devices without ever going through the
> necessary fixup bits and pieces that normal PCI devices go through.
> There's in fact a commented out call to pcibios_fixup_bus() in there,
> it's commented because ... it doesn't work.
> I could make pcibios_fixup_bus() do the right thing on powerpc easily
> but I felt it cleaner instead to provide a specific hook
> pci_fixup_cardbus for which a weak empty implementation is provided
> by the PCI core.
> This fixes cardbus on powerbooks and probably all other PowerPC
> platforms which was broken completely for ever on some platforms and
> since 2.6.31 on others such as PowerBooks when we made the DMA ops
> mandatory (since those are setup by the fixups).
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>

Applied, thanks.  Had to fix up a conflict since someone had "helpfully"
changed the comment from a // to a /* .. */ in cardbus.c.

Jesse Barnes, Intel Open Source Technology Center

More information about the Linuxppc-dev mailing list