[PATCH v2] cpm2_pic: Allow correct flow_types for port C interrupts

Mark Ware mware at elphinstone.net
Thu Dec 10 22:10:16 EST 2009

Scott Wood wrote:
> Anton Vorontsov wrote:
>>> +        if ((flow_type != IRQ_TYPE_EDGE_BOTH) && +           
>>> (flow_type != IRQ_TYPE_EDGE_FALLING)) {
>> I'd place one more tab here.
> Or better, align one "flow_type" with the other.
> -Scott

Thanks Anton and Scott.

Scott's suggestion is also my preferred style, but a (brief) search through the source didn't reveal much support.

I'll send a new version shortly including you suggestions.

- Mark

More information about the Linuxppc-dev mailing list