[RFC PATCH v3 3/3] powerpc: gamecube/wii: early debugging using usbgecko
Segher Boessenkool
segher at kernel.crashing.org
Thu Dec 3 15:06:34 EST 2009
>>> you may want to rename the ug_ prefix, it took me a while looking
>>> back
>>> and forth through the patch to convince myself it wasn't a typo.
>>
>> What's wrong with ug_ ? (ug = (u)sb(g)ecko)
>
> At first look I thought it was a typo of udbg_early_remap. I prefer
> the longer names although we could use gecko_early_remap unless the
> gecko prefix conflicts with anything else.
All these names are local to this file. Shorter names are nicer than
longer names :-)
> If there is not going to be a non usb gecko then there is no need
> to have usb in the prefix.
There already is a Gecko device that plugs into the memory card slot
as well. It is older than the USB Gecko, and much more widespread.
It doesn't give you a serial connection, it's memory only.
Segher
More information about the Linuxppc-dev
mailing list