[PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

Mikael Pettersson mikpe at it.uu.se
Tue Dec 1 21:48:09 EST 2009


Benjamin Herrenschmidt writes:
 > This is a libata driver for the "macio" IDE controller used on most Apple
 > PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
 > 
 > It supports all the features of its predecessor, including mediabay hotplug
 > and suspend/resume. It should also support module load/unload.
 > 
 > The timing calculations have been simplified to use pre-calculated tables
 > compared to drivers/ide/pmac.c and it uses the new mediabay interface
 > provided by a previous patch.
 > 
 > Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
 > ---
 > 
 > Only lightly tested so far, this is for review, NOT for merge.
 > 
 > I would like to merge it eventually via the powerpc tree since there's a
 > few dependent patches, though I would need the libata "fix" for
 > bmdma_stop to go in first, unless I carry it as well with appropriate
 > acks.
 > 
 > I have addressed some of the comments from the previous version (almost a
 > year ago I think). I have kept the single function for the PIO and DMA
 > timings due to the one bit overlap between the fields in the HW register
 > on the shasta chipset. It seems to work fine.

Thanks for reviving pata_macio.

Does the new version work with yaboot? (the previous one didn't)

/Mikael


More information about the Linuxppc-dev mailing list