[PATCH V2 3/3] powerpc/pci: Merge ppc32 and ppc64 versions of phb_scan()

Grant Likely grant.likely at secretlab.ca
Sat Aug 29 04:42:07 EST 2009

On Wed, Aug 26, 2009 at 11:46 PM, Benjamin
Herrenschmidt<benh at kernel.crashing.org> wrote:
> On Wed, 2009-08-26 at 00:07 -0600, Grant Likely wrote:
>> From: Grant Likely <grant.likely at secretlab.ca>
>> The two versions are doing almost exactly the same thing.  No need to
>> maintain them as separate files.  This patch also has the side effect
>> of making the PCI device tree scanning code available to 32 bit powerpc
>> machines, but no board ports actually make use of this feature at this
>> point.
> You missed various calls to scan_phb() in arch/powerpc :-)
> At least pSeries with dynamic LPAR is broken

Oops, yup.  I also broke CONFIG_PPC_OF_PLATFORM_PCI in of_platform.c.
Fixed now.

> I think iSeries might break too.

iSeries has its own unrelated scan_phb() implementation.  I don't
think I broke it.

> Try a ppc64_defconfig.


> I tentatively applied the other patches to -test

Thanks.  New scan_phb() patch to follow.


Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

More information about the Linuxppc-dev mailing list