[PATCH v2] qe_lib: Set gpio data before changing the direction to output
galak at kernel.crashing.org
Wed Aug 26 00:44:59 EST 2009
On Aug 18, 2009, at 4:20 PM, Michael Barkowski wrote:
> This avoids having a short glitch if the desired initial value is not
> the same as what was previously in the data register.
> Signed-off-by: Michael Barkowski <michaelbarkowski at ruggedcom.com>
> Anton Vorontsov wrote:
>> There is a recursive locking bug: _set() takes the same spinlock.
>> So you'd better move this call two lines upper. Otherwise the
>> patch looks OK.
> Thanks - here is v2.
> arch/powerpc/sysdev/qe_lib/gpio.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
applied to next.
More information about the Linuxppc-dev