[PATCH] powerpc: Change archdata dma_data type to dma_addr_t
Christoph Hellwig
hch at lst.de
Tue Aug 25 05:48:00 EST 2009
On Mon, Aug 24, 2009 at 11:17:14AM -0500, Becky Bruce wrote:
> Previously, this was specified as a void *, but that's not
> large enough on 32-bit systems with 36-bit physical
> addressing support. Change the type to dma_addr_t so it
> will scale based on the size of a dma address.
This looks extreml ugly to me. It seems like the typical use is to
store a pointer to a structure. So what about making the direct
dma case follow that general scheme instead?
E.g. declare a
struct direct_dma_data {
dma_addr_t direct_dma_offset;
};
and have one normal instace of it, and one per weird cell device.
More information about the Linuxppc-dev
mailing list