linux-next: powerpc tree build warning

Christoph Hellwig hch at lst.de
Mon Aug 24 11:01:53 EST 2009


On Mon, Aug 24, 2009 at 10:22:56AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
> 
> kernel/time/tick-sched.c: In function 'tick_nohz_stop_sched_tick':
> kernel/time/tick-sched.c:261: warning: format '%02x' expects type 'unsigned int', but argument 2 has type 'long unsigned int'
> 
> Introduced by commit 6826a57d1abc8ac9f59b24f1a008554c6560a995 ("powerpc:
> Switch to asm-generic/hardirq.h") which changed
> irq_cpustat_t::__softirq_pending from "unsigned int" to "unsigned long"
> on powerpc.

Hah, that's an interesting one.  In currently mainline the following
architectures have it as unsigned long:

	alpha, parisc and blackfin/microblaze via asm-generic

and all others have it as unsigned int.  For blackfin and microblaze
it obviously doesn't matter, so the question is why alpha and parisc
have it as usinged long.  We defintively should standardize on one,
and unless alpha and parisc have good reasons for needing a long
value that would be unsigned int.


More information about the Linuxppc-dev mailing list