[PATCH] sbc8560: Fix warm reboot with board specific reset function

[Kumar Gala]

On Aug 14, 2009, at 9:43 AM, Paul Gortmaker wrote:

> Kumar Gala wrote:
>> On Aug 13, 2009, at 6:06 PM, Paul Gortmaker wrote:
>>> From: Liang Li <Liang.Li at windriver.com>
>>>
>>> The existing fsl_rstcr_restart function fails to reset the sbc8560
>>> board. This implements a board specific reset function that uses
>>> the RCR(Reset Control Register) of the board's EPLD to do a reset.
>>>
>>> Signed-off-by: Liang Li <Liang.Li at windriver.com>
>>> Signed-off-by: Paul Gortmaker <paul.gortmaker at windriver.com>
>>> ---
>>> arch/powerpc/platforms/85xx/sbc8560.c |   39 ++++++++++++++++++++++ 
>>> ++++++++++-
>>> 1 files changed, 38 insertions(+), 1 deletions(-)
>> The reason it didn't was that feature doesnt exist on the mpc8560 :)
>
> I could see how that might have an impact on the
> functionality.... :-)
>
> So, what should the guts block of the 8560 dts look
> like? It currently has the standard:
>
> ------------
> global-utilities at e0000 {
>  compatible = "fsl,mpc8560-guts";
>  reg = <0xe0000 0x1000>;
>  fsl,has-rstcr;
> };
> ------------
>
> MPC8560 has a guts block, but saying "has-rstcr", as
> you've pointed out, is a bit of a lie. If we remove that
> tag, then we'll trip the:
>
> printk(KERN_INFO "rstcr compatible register does not exist!\n");
>
> which isn't the end of the world, but at the moment it
> reads more like an error message, vs. an informative one.

we should probably remove 'fsl,has-rstcr' from the .dts since that's  
just wrong.  I've got no issue w/either removing the warning or  
changing its wording.

- k