[PATCH] [MTD] ofpart: Partitions at same address cannot have thesame name v3

Ricardo Ribalda Delgado ricardo.ribalda at uam.es
Wed Apr 29 17:41:52 EST 2009


Hello Segher

  Thanks for your comments.

>
> Your special "partition" isn't really a partition then, is it.
> Because of that, device nodes to represent your partitions doesn't
> work very well.

I think that they work pretty well. Unfortunately, since
4b08e149c0e02e97ec49c2a31d14a0d3a02f8074 all the partiton must be
named "partition"

>
> You really want to use something else, a partition table on the
> flash itself for example.  Or maybe the (platform? MTD?) code
> should create a Linux device for the "full" device.

This wont be very flexible. With the device tree aproach we can define
partitions not only for the full flash, but also for two partitions
merged, a partition inside a partition....

>
>> Because two nodes of a device tree cannot have the same name,
>
> This isn't true.

Are you sure? This is what I get if I try to compile a device tree
with two partitions with the same name starting at the same address.

$ arch/powerpc/boot/dtc -O dtb -b 0 -p 1024
arch/powerpc/boot/dts/q5-avnet.dts -o /tmp/kk
DTC: dts->dtb  on file "arch/powerpc/boot/dts/q5-avnet.dts"
ERROR (duplicate_node_names): Duplicate node name
/plb at 0/flash at ff000000/partition at ff000000
ERROR: Input tree has errors, aborting (use -f to force output)



>
>> but all the
>> partitions must be named "partition",
>
> Bad binding, no cookie for you!

Sorry, I dont understand want you want to say here.


> You cannot claim a name as generic as "partition" for this.  Pick
> something else if you really must do things this way.


You choose :)


         Best regards


-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/



More information about the Linuxppc-dev mailing list