[PATCH v3] powerpc/85xx: Add P2020DS board support

[Kumar Gala]

On Apr 22, 2009, at 11:44 AM, Scott Wood wrote:

> On Tue, Apr 21, 2009 at 10:31:45PM -0500, Kumar Gala wrote:
>> +	localbus at ffe05000 {
>> +		#address-cells = <2>;
>> +		#size-cells = <1>;
>> +		compatible = "fsl,elbc", "simple-bus";
>
> If this has an elbc more recent than 1.0 (looks like it), we should
> indicate that here.

that might be the case, but I leave it to u-boot to do that.

>> +		reg = <0 0xffe00000 0 0x1000>;	// CCSRBAR & soc regs, remove  
>> once parse code for immrbase fixed
>
> The immrbase code was fixed a long time ago -- this can go away.

will remove

>> +static int __init p2020_ds_probe(void)
>> +{
>> +	unsigned long root = of_get_flat_dt_root();
>> +
>> +	if (of_flat_dt_is_compatible(root, "fsl,P2020DS")) {
>> +#ifdef CONFIG_PCI
>> +		primary_phb_addr = 0x9000;
>> +#endif
>> +		return 1;
>> +	} else {
>> +		return 0;
>> +	}
>> +}
>
> Unnecessary "else".

will fix this and the 2 other cases it shows up on.

- k