[PATCH] [V4] Xilinx : Framebuffer Driver: Add PLB support and cleanup DCR

Grant Likely grant.likely at secretlab.ca
Fri Apr 17 05:01:42 EST 2009

On Thu, Apr 16, 2009 at 10:26 AM, John Linn <john.linn at xilinx.com> wrote:
> Added support for the new xps tft controller. The new core
> has PLB interface support in addition to existing DCR interface.
> Removed platform device support as both MicroBlaze and PowerPC
> use device tree.
> Previously, the dcr interface was assumed to be used in mmio mode,
> and the register space of the dcr interface was precomputed and stuffed
> into the device tree. This driver now makes use of the new dcr
> infrastructure to represent the dcr interface. This enables the dcr
> interface to be connected directly to a native dcr interface in a clean
> way.
> Added compatibility for ml507 dvi core.
> Signed-off-by: Suneel <suneelg at xilinx.com>
> Signed-off-by: Stephen Neuendorffer <stephen.neuendorffer at xilinx.com>
> Signed-off-by: John Linn <john.linn at xilinx.com>
> ---
> V2 - cleanup based on review
> V3 - update to be based on top of tree rather than Xilinx tree, sorry for the
>  confusion with this, update the name of the patch slightly to be more accurate
> V4 - update based on Grant's comments to simplify it, the binding wasn't changed
>  as the conversation seemed to verify it's acceptable

Actually Stephen and I agreed that the driver should *not* go looking
for the xlnx,dcr-splb-slave-if property.  reg and dcr-reg are
sufficient.  If a driver has both properties, then either method of
access will work.

> @@ -107,12 +112,21 @@ static struct fb_var_screeninfo xilinx_fb_var = {
>        .activate =     FB_ACTIVATE_NOW
>  };
> +
> +#define PLB_ACCESS_FLAG        0x1             /* 1 = PLB, 0 = DCR */
> +

Also, this define is no longer required.


Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

More information about the Linuxppc-dev mailing list