[PATCH] [V3] Xilinx : Framebuffer Driver: Add PLB support and cleanup DCR

[Stephen Neuendorffer]

> > -       rc = of_address_to_resource(op->node, 0, &res);
> > -       if (rc) {
> > -               dev_err(&op->dev, "invalid address\n");
> > -               return rc;
> > +       /*
> > +        * To check whether the core is connected directly to DCR or PLB
> > +        * interface and initialize the tft_access accordingly.
> > +        */
> > +       p = (u32 *)of_get_property(op->node, "xlnx,dcr-splb-slave-if", NULL);
> 
> Hmmm.  This binding is undocumented.  It would be better to make the
> decision on the presence/absence of the dcr-reg and/or reg properties.

For backward compatibility with the 'old' way, the device tree generator for this core has both dcr-reg and reg properties (where the reg has been translated back through the bridge).   

You're probably right that it should just be one or the other, but the device tree generator change needs to be synchronized, and it will break backward compatibility with the older driver.

Steve 

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.