[PATCH] [V3] Xilinx : Framebuffer Driver: Add PLB support and cleanup DCR

[Grant Likely]

On Wed, Apr 15, 2009 at 9:58 AM, Stephen Neuendorffer
<stephen.neuendorffer at xilinx.com> wrote:
>> > -       rc = of_address_to_resource(op->node, 0, &res);
>> > -       if (rc) {
>> > -               dev_err(&op->dev, "invalid address\n");
>> > -               return rc;
>> > +       /*
>> > +        * To check whether the core is connected directly to DCR or PLB
>> > +        * interface and initialize the tft_access accordingly.
>> > +        */
>> > +       p = (u32 *)of_get_property(op->node, "xlnx,dcr-splb-slave-if", NULL);
>>
>> Hmmm.  This binding is undocumented.  It would be better to make the
>> decision on the presence/absence of the dcr-reg and/or reg properties.
>
> For backward compatibility with the 'old' way, the device tree generator for this core has both dcr-reg and reg properties (where the reg has been translated back through the bridge).

So, what is in the regs and dcr-regs properties when DCR is used?

How about when MMIO is used?

g.


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.