[v1 PATCH 1/1] Fix 64bit Maple Host Bridge Address and Size Nodes

Segher Boessenkool segher at kernel.crashing.org
Tue Apr 14 18:11:02 EST 2009


> In the DTB tree created by firmware on some Maple 64bit targets,  
> such as ATCA6101,
> these two properties, address&size, should be 2.

And they are.

> But the actual corresponding values
> of host bridge node are set 1 incorrectly by the firmware, we have  
> to provide one
> fixup function to fix that.

It is the "reg" property that is incorrectly encoded as-if
#address-cells and #size-cells were 1.

Please fix the commit message (and subject line).

> +	name = "/hostbridge at f8000000";
> +	hb = call_prom("finddevice", 1, 1, ADDR(name));

It's interesting that the firmware can find your node this way,
it won't match the "reg"!  Looks like there is more than one
bug in there.

Code looks good,

Reviewed-by: Segher Boessenkool <segher at kernel.crashing.org>


Segher




More information about the Linuxppc-dev mailing list