[PATCH] Quieten arch/powerpc in a allmodconfig build.

[Geert Uytterhoeven]

On Wed, 8 Apr 2009, Michael Ellerman wrote:
> On Wed, 2009-04-08 at 15:51 +1000, Tony Breeds wrote:
> > On Wed, Apr 08, 2009 at 03:08:55PM +1000, Michael Ellerman wrote:
> > 
> > > The getter routines in here could really multiplex their return values
> > > with a negative error code, which I generally prefer, but this works I
> > > guess.
> > 
> > I was hoping someone would notice and suggest it.  tag you're it!
> 
> I meant we /could/ change them, but we could also leave them, it's a bit
> of a coin-flip which is better. Nathan might have an opinion?
> 
> Something like this:
> 
> diff --git a/arch/powerpc/kernel/cacheinfo.c b/arch/powerpc/kernel/cacheinfo.c
> index bb37b1d..9f3a155 100644
> --- a/arch/powerpc/kernel/cacheinfo.c
> +++ b/arch/powerpc/kernel/cacheinfo.c

> -static int cache_size_kb(const struct cache *cache, unsigned int *ret)
> +static int cache_size_kb(const struct cache *cache)
>  {
>         unsigned int size;
          ^^^^^^^^^^^^
`int size', or Roel will come to get you ;-)

>  
> -       if (cache_size(cache, &size))
> -               return -ENODEV;
> +       size = cache_size(cache);
> +       if (size < 0)
              ^^^^^^^^
> +               return size;

I can't check the others, due to lacking context...

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Techsoft Centre Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone:    +32 (0)2 700 8453
Fax:      +32 (0)2 700 8622
E-mail:   Geert.Uytterhoeven at sonycom.com
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 · RPR Brussels
Fortis · BIC GEBABEBB · IBAN BE41293037680010