[PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines

Timur Tabi timur at freescale.com
Mon Apr 6 05:18:20 EST 2009


On Sun, Apr 5, 2009 at 9:59 AM, Kumar Gala <galak at kernel.crashing.org> wrote:

> No, I think we should just fix drivers.  There aren't that many SoC drivers
> and once they are fixed this will resolve itself.

I agree.  The only reason I passed NULL when I wrote the drivers was
because I was too lazy to figure out what the right dev pointer was.
ASoC is kinda screwy in that many fields are not initialized when you
think they should be.  More than once I passed a pointer to a wrong
object without realizing it, even though the code worked.

I'll check out these two patches on Monday.

-- 
Timur Tabi
Linux kernel developer at Freescale



More information about the Linuxppc-dev mailing list