[Bugme-new] [Bug 11629] New: quad G5 fails to shut down

Joel Schopp jschopp at austin.ibm.com
Sat Sep 27 05:17:26 EST 2008


> From: Johannes Berg <johannes at sipsolutions.net>
> Subject: powerpc: fix shutdown
>
> I tracked down the shutdown regression to CPUs not dying
> when being shut down during power-off. This turns out to
> be due to the system_state being SYSTEM_POWER_OFF, which
> this code doesn't take as a valid state for shutting off
> CPUs in.
>
> This has never made sense to me, but when I added hotplug
> code to implement hibernate I only "made it work" and did
> not question the need to check the system_state. Thomas
> Gleixner helped me dig, but the only thing we found is
> that it was added with the original commit that added CPU
> hotplug support.
>
> Signed-off-by: Johannes Berg <johannes at sipsolutions.net>
> Cc: Thomas Gleixner <tglx at linutronix.de>
> Cc: Joel Schopp <jschopp at austin.ibm.com>
> Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
>   
Tested this patch on a Power6 partition with cpu hotplug online/offline 
and some shutdown and reboot cycles.  Didn't see any ill effects.

Acked-by: Joel Schopp <jschopp at austin.ibm.com>





More information about the Linuxppc-dev mailing list