take in count O_NONBLOCK flag for rtas log

David Howells dhowells at redhat.com
Fri Sep 26 07:13:05 EST 2008


Vitaly Mayatskikh <v.mayatskih at gmail.com> wrote:

> +		if (!logging_enabled) {
> +			spin_unlock_irqrestore(&rtasd_log_lock, s);
> +			error = -ENODATA;
> +			goto out;
> +		} else
> +			nvram_clear_error_log();

The 'else' here is unnecessary.  It's preceded inside the curlies by a goto.

David



More information about the Linuxppc-dev mailing list