Vitaly Mayatskikh <v.mayatskih at gmail.com> wrote: > + if (!logging_enabled) { > + spin_unlock_irqrestore(&rtasd_log_lock, s); > + error = -ENODATA; > + goto out; > + } else > + nvram_clear_error_log(); The 'else' here is unnecessary. It's preceded inside the curlies by a goto. David