[PATCH v2] powerpc: gpio driver for mpc8349/8572/8610 and compatible

[Kumar Gala]

On Sep 21, 2008, at 2:46 PM, Peter Korsgaard wrote:

> +GPIO controllers on MPC8xxx SoCs
> +
> +Every GPIO controller node must have #gpio-cells property defined,
> +this information will be used to translate gpio-specifiers.
> +

Can we add a comment about this being the non-QE/CPM/GUTs GPIO  
support.  And maybe a reference to the 8349 as an example of the  
controller if unsure about the compatibility.

Also, does it make sense to have a reference to the top-level generic  
GPIO info w/regards to pin specific info, etc..

> +Required properties:
> +- compatible : "fsl,<CHIP>-gpio" followed by "fsl,mpc8349-gpio" for
> +  83xx, "fsl,mpc8572-gpio" for 85xx and "fsl,mpc8610-gpio" for 86xx.
> +- #gpio-cells : Should be two. The first cell is the pin number and  
> the
> +  second cell is used to specify optional parameters (currently  
> unused).
> + - interrupts : Interrupt mapping for GPIO IRQ (currently unused).
> + - interrupt-parent : Phandle for the interrupt controller that
> +   services interrupts for this device.
> +- gpio-controller : Marks the port as GPIO controller.

- k