[PATCH v2] Add AMCC Arches eval board support to platforms/44x

Victor Gallardo vgallardo at amcc.com
Sat Sep 20 03:31:34 EST 2008


 
Hi Josh,

See below...

>> ...
>> @@ -83,9 +83,23 @@ config CANYONLANDS
>>  	select 460EX
>>  	select PCI
>>  	select PPC4xx_PCI_EXPRESS
>> +	select IBM_NEW_EMAC_EMAC4
>> +	select IBM_NEW_EMAC_RGMII
>> +	select IBM_NEW_EMAC_ZMII
>> +	select IBM_NEW_EMAC_TAH
>>  	help
>>  	  This option enables support for the AMCC PPC460EX evaluation board.
>> 
>> +config ARCHES
>> +	bool "Arches"
>> +	depends on 44x
>> +	default n
>> +	select 460EX
>> +	select IBM_NEW_EMAC_EMAC4
>> +	select IBM_NEW_EMAC_TAH
>> +	help
>> +	  This option enables support for the AMCC PPC460GT evaluation board.
>
>This seems fine.
>
> ...
>
>> +obj-$(CONFIG_ARCHES)	+= canyonlands.o
>>  obj-$(CONFIG_CANYONLANDS) += canyonlands.o
>>  obj-$(CONFIG_XILINX_VIRTEX_5_FXT) += virtex.o
>
>Instead of modifying the Makefile, you should only have to add the "amcc,arches"
> string to the >"board" array in ppc44x_simple.c.
>
> We switched to doing this as opposed to having a somewhat bogus 
> "board compatible" statement with >other boards.  That is what was discussed at
> OLS, and this is the result.

The reason for two different board types is to remove RGMII and ZMII from the build. Arches does not use it.

Where is ppc4xx_simple.c? I just pulled your git tree and did not find this file.

Thanks,

Victor Gallardo



More information about the Linuxppc-dev mailing list