[RFC] adding hwmon support to sequoia device tree

[Sean MacLennan]

Yes, the ad7414 driver was finally accepted into the kernel. The ad7414 is a generic temperature chip.

FWIW, the warp.dts uses ad7414 at 4c, not hwmon.

Cheers,
   Sean

-----Original Message-----
From:	linuxppc-dev-bounces+smaclennan=pikatech.com at ozlabs.org on behalf of Matthias Fuchs
Sent:	Thu 9/4/2008 10:28 AM
To:	Josh Boyer
Cc:	linuxppc-dev at ozlabs.org
Subject:	Re: [RFC] adding hwmon support to sequoia device tree

Hi, 

On Thursday 04 September 2008 14:25, Josh Boyer wrote:
> On Thu, Sep 04, 2008 at 11:55:02AM +0200, Matthias Fuchs wrote:
> >Hi,
> >
> >I added support for the Sequoia on-board I2C temperature sensor to the device.
> >I am not sure if there is any node naming convention for such devices.
> >The needed I2C driver can be found under drivers/hwmon in the kernel sources,
> >so I found "hwmon" suitable for the node.
> >
> >Do we want to add this to the sequoia dts file? If this is how it should be done,
> >I will commit a proper patch.
> 
> See comments below.  Out of curiosity, do you have a working driver and
> setup with this?
Of course. 

You need
	CONFIG_HWMON=y
	CONFIG_SENSORS_AD7414=y

Via sysfs you get:
sequoia:~# cat /sys/bus/i2c/devices/0-0048/temp1_input
34750
sequoia:~# cat /sys/class/hwmon/hwmon0/device/temp1_input
34750
sequoia:~# 

34750 = 34.75°C

> 
> >diff --git a/arch/powerpc/boot/dts/sequoia.dts b/arch/powerpc/boot/dts/sequoia.dts
> >index 72d15f0..82fdfdf 100644
> >--- a/arch/powerpc/boot/dts/sequoia.dts
> >+++ b/arch/powerpc/boot/dts/sequoia.dts
> >@@ -246,13 +246,23 @@
> >                        };
> >
> >                        IIC0: i2c at ef600700 {
> >+                               #address-cells = <1>;
> >+                               #size-cells = <0>;
> >                                compatible = "ibm,iic-440epx", "ibm,iic";
> >                                reg = <0xef600700 0x00000014>;
> >                                interrupt-parent = <&UIC0>;
> >                                interrupts = <0x2 0x4>;
> >+
> >+                               hwmon at 48 {
> >+                                       device_type = "hwmon";
> 
> We don't need device_type.  Particularly not a new one like this.
I will remove that.
> 
> >+                                       compatible = "analog,ad7414";
> 
> Perhaps 'compatible = "analog,ad7417", "amcc,hwmon-440epx";'
It has nothing to do with either AMCC or 440EPx.

Patch is on the way.

Matthias
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev at ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev