[PATCH 3/3] ibm_newemac: MAL support for PowerPC 405EZ

Benjamin Herrenschmidt benh at kernel.crashing.org
Fri Sep 5 19:34:38 EST 2008


> > > +	if (of_device_is_compatible(ofdev->node, "ibm,mcmal-405ez"))
> > > +		mal->features |= (MAL_FTR_CLEAR_ICINTSTAT | MAL_FTR_COMMON_ERR_INT);
> > 
> > The above like is >80 characters wide.
> > But I'm not sure that anyone cares.
> 
> I don't.  If Ben complains I'll change it.

I wouldn't do a tatrum over it but if you're going to respin the
patch you may as well put the second constant on the next line.

Cheers,
Ben.





More information about the Linuxppc-dev mailing list