[PATCH 2/3] ibm_newemac: Introduce mal_has_feature

[Benjamin Herrenschmidt]

On Thu, 2008-09-04 at 11:02 -0400, Josh Boyer wrote:
> There are some PowerPC SoCs that do odd things with the MAL handling.  In
> order to accommodate them, we need to introduce a feature mechanism that is
> similar to the existing emac_has_feature function.
> 
> This adds a feature variable to the mal_instance structure, and adds a
> mal_has_feature function with some feature definitions.  These are guarded
> by Kconfig options that are selected by the affected platforms.
> 
> Signed-of-by: Josh Boyer <jwboyer at linux.vnet.ibm.com>

You also add an actual feature (CLR_ICINSTAT). You should document that
or move it to a separate patch.

> +/* Features of various MAL implementations */
> +
> +/* Dummy feature bit so the enum works properly */
> +#define MAL_FTR_DUMMY	0x00000001

Nah. Just stick an | 0 in the enum to make it happy.

Cheers,
Ben.