[PATCH v3] usb: add Freescale QE/CPM USB peripheral controller driver

Li Yang leoli at freescale.com
Wed Sep 3 13:51:39 EST 2008


On Tue, Sep 2, 2008 at 8:01 PM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Tuesday 02 September 2008, Li Yang wrote:
>> Some of Freescale SoC chips have a QE or CPM co-processor which
>> supports full speed USB.  The driver adds device mode support
>> of both QE and CPM USB controller to Linux USB gadget.  The
>> driver is tested with MPC8360 and MPC8272, and should work with
>> other models having QE/CPM given minor tweaks.
>>
>> Signed-off-by: Xie Xiaobo <X.Xie at freescale.com>
>> Signed-off-by: Li Yang <leoli at freescale.com>
>
> Acked-by: Arnd Bergmann <arnd at arndb.de>
>
> All my previous review comments have been addressed.
>
>> +     udc_controller->soc_type = (unsigned long)np->data;
>
> I'm not sure about this line, shouldn't that be
>        udc_controller->soc_type = (unsigned long)match->data; ?

Oops.  You are right.

- Leo



More information about the Linuxppc-dev mailing list