[v5] powerpc: gpio driver for mpc8349/8572/8610 and compatible

[Kumar Gala]

On Oct 30, 2008, at 3:58 AM, Trent Piepho wrote:

> On Thu, 30 Oct 2008, Peter Korsgaard wrote:
>>>>>>> "Trent" == Trent Piepho <tpiepho at freescale.com> writes:
>> Trent> On Tue, 23 Sep 2008, Peter Korsgaard wrote:
>>>> +- compatible : "fsl,<CHIP>-gpio" followed by "fsl,mpc8349-gpio"  
>>>> for
>>>> +  83xx, "fsl,mpc8572-gpio" for 85xx and "fsl,mpc8610-gpio" for  
>>>> 86xx.
>>
>> Trent> Why have the three different compatible settings when the code
>> Trent> doesn't do anything different?
>>
>> Purely for cosmetics / ease of use - As requested by Kumar:
>>
>> http://ozlabs.org/pipermail/linuxppc-dev/2008-September/062934.html
>
> Though I see Scott didn't agree.

Yep ;)

>>>> +#define MPC8XXX_GPIO_PINS	32
>>
>> Trent> 8572 has eight GPIOs.
>>
>> Doesn't matter - It's register interface is compatible. Most real
>> world design with the other SoCs also don't have all 32 gpio pins
>> available because of pin multiplexing.
>
> Doesn't it seem flawed that 32 gpios will show up under debugfs and  
> via the
> sysfs interface, when it's known that there are only 8?
>
> Since there is an 8572 compat property, it's not like it's not  
> solvable.

seem like a patch is order

>> Trent> I wrote an MPC8572 GPIO driver back in March, and posted it
>> Trent> internally at Freescale on June 2nd.  But it was just
>> Trent> ignored...  I wonder what your secret is to get Kumar to apply
>> Trent> your patches?  It's too bad this work keeps getting
>> Trent> duplicated.
>>
>> Did you try bribing? ;) No, seriously, why didn't you post it to
>> linuxppc-dev, so the rest of the world would know about it?
>
> Well, I get totally ignored posting to an internal Freescale list,  
> it doesn't
> seem like it will be any better posting to an external list.

Trent I'm not ignoring you, its just I've got a lot of things on my  
plate.  I expect other to comment internally to FSL and wait til  
something gets posted externally to pay attention.  This way its  
hopefully been reviewed and commented by a number of people before I  
look at it.

Also, we have patchworks externally so I have an explicit todo list  
that I can track.

Don't feel bad.  I've ignored patches from others ;)

- k