[PATCH] AMCC Crypto4xx Device Driver v2]

[Josh Boyer]

On Wed, 29 Oct 2008 10:04:59 -0700
James Hsiao <jhsiao at amcc.com> wrote:
> > > > - Complete lack of locking code, how do you enforce mutually exclusive
> > > > access to the device?
> > > 
> > > The crypto engine have couple bits 'command ready' and 'packet done',
> > > which servers as semaphore here. So, software don't need extra locking.
> > 
> > know if it's applicable at all, but I imagine it's not SMP safe.
> 
> No, it's not SMP safe. This driver only support single core processors.

What about preemption?  You do not have to be a multi-core CPU to have
SMP-like problems.

josh