[PATCH] [powerpc] GPIO: Adding new Xilinx driver

[Anton Vorontsov]

On Sat, Oct 25, 2008 at 12:07:06AM -0600, Grant Likely wrote:
> On Fri, Oct 24, 2008 at 3:41 PM, Anton Vorontsov
> <avorontsov at ru.mvista.com> wrote:
> > On Fri, Oct 24, 2008 at 12:59:00PM -0700, John Linn wrote:
> >> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> >> index 7f2ee27..f6b0da8 100644
> >> --- a/drivers/gpio/Kconfig
> >> +++ b/drivers/gpio/Kconfig
> >> @@ -65,6 +65,14 @@ config GPIO_SYSFS
> >>
> >>  # put expanders in the right section, in alphabetical order
> >>
> >> +comment "Memory mapped GPIO expanders:"
> >> +
> >> +config GPIO_XILINX
> >> +     bool "Xilinx GPIO support"
> >> +     depends on OF
> >
> > I persume that the driver wasn't build-tested on SPARC, so I'd recommend
> > to change the depends to PPC_OF. Plus, the driver should also select
> > GENERIC_GPIO and ARCH_REQUIRE_GPIOLIB. (Later we'll switch to
> > ARCH_WANT_OPTIONAL_GPIOLIB for whole PPC.)
> 
> ARCH_WANT_OPTIONAL_GPIOLIB seems to already be set for all of powerpc
> (arch/powerpc/Kconfig, line 113).

Ah yes, I see it now. Thanks.

-- 
Anton Vorontsov
email: cbouatmailru at gmail.com
irc://irc.freenode.net/bd2