odd change to drivers/net/ibm_newemac/core.c

Christoph Hellwig hch at lst.de
Fri Oct 24 08:41:48 EST 2008


+#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL
                        dev->features |= EMAC_FTR_NO_FLOW_CONTROL_40x;
+#else
+                       printk(KERN_ERR "%s: Flow control not disabled!\n",
+					np->full_name);
+                       return -ENXIO;
+#endif

What's this trying to do?  CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL doesn't
exist anywhere, and it seems like an extremly strange idea for a config
option.  And "Flow control not disabled" is not an extremly useful error
message for users either..



More information about the Linuxppc-dev mailing list