linux-next: ttydev tree build failure
Stephen Rothwell
sfr at canb.auug.org.au
Thu Oct 23 17:29:38 EST 2008
Hi Alan,
Today's linux-next build (powerpc ppc64_defconfig) failed like this:
drivers/char/hvc_console.c: In function 'hvc_set_winsz':
drivers/char/hvc_console.c:532: warning: passing argument 2 of 'tty_do_resize' from incompatible pointer type
drivers/char/hvc_console.c:532: error: too many arguments to function 'tty_do_resize'
Caused by commit eb6ab2d361a49470ca9785c70482772c19e49bec
("pty-simplify-resize") from the ttydev tree interacting with commit
febde3711992a64ea83a47a719f68a90c4b0927a ("hvc_console: Add support for
tty window resizing").
The former added another call to the function that the latter changed.
I applied the following patch.
--
Cheers,
Stephen Rothwell sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell <sfr at canb.auug.org.au>
Date: Thu, 23 Oct 2008 17:26:51 +1100
Subject: [PATCH] hvc_console: fallout from tty_do_resize change
Signed-off-by: Stephen Rothwell <sfr at canb.auug.org.au>
---
drivers/char/hvc_console.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/hvc_console.c b/drivers/char/hvc_console.c
index 5b819b1..65f88ef 100644
--- a/drivers/char/hvc_console.c
+++ b/drivers/char/hvc_console.c
@@ -529,7 +529,7 @@ static void hvc_set_winsz(struct work_struct *work)
tty = tty_kref_get(hp->tty);
spin_unlock_irqrestore(&hp->lock, hvc_flags);
- tty_do_resize(tty, tty, &ws);
+ tty_do_resize(tty, &ws);
tty_kref_put(tty);
}
--
1.5.6.5
More information about the Linuxppc-dev
mailing list