[PATCH] Fix linking modules against crtsavres.o

[Kumar Gala]

On Oct 16, 2008, at 10:24 AM, Grant Likely wrote:

> On Thu, Oct 09, 2008 at 09:51:25PM +0200, Bernhard Reutner-Fischer  
> wrote:
>> Hi,
>>
>> [ http://bugzilla.kernel.org/show_bug.cgi?id=11143 has it all]
>>
>> targeting ppc(32), e.g. 405 (!fp), previously i got:
>>  CC      drivers/char/hw_random/rng-core.mod.o
>>  LD [M]  drivers/char/hw_random/rng-core.ko
>> /there/src/buildroot.git.ppc/build_powerpc_nofpu/staging_dir/usr/ 
>> bin/powerpc-linux-uclibc-ld:
>> arch/powerpc/lib/crtsavres.o: No such file: No such file or directory
>>
>> 	* Makefile (LDFLAGS_MODULE_PREREQ): New variable to hold  
>> prerequisite
>> 	files for modules.
>> 	* arch/powerpc/Makefile: add crtsavres.o to LDFLAGS_MODULE_PREREQ.
>> 	* scripts/Makefile.modpost (cmd_as_o_S): Copy from Makefile.build.
>> 	(cmd_ld_ko_o): Also link LDFLAGS_MODULE_PREREQ.
>> 	Provide rule to build objects from assembler.
>>
>> The attached patch (same as attached to abovementioned bug) fixes  
>> this.
>> I'm asking the ppc maintainers or you, Sam, to consider something to
>> that effect for inclusing in the stable series.
>> thanks,
>
> This patch solves the problem for me.  Without it building modules
> before the kernel proper fails to find crtsavres.o when linking.
>
> Ben, Paul or Sam, could you please look at this and make comment
> if it is the right approach?
>
> I also agree that this should be back ported to the stable series
>
> (Note: for some reason this patch did *not* show up in patchwork).

because it was sent as an attachment.

- k