[PATCH] remove bogus ppc_select syscall
Paul Mackerras
paulus at samba.org
Fri Oct 10 18:43:31 EST 2008
Benjamin Herrenschmidt writes:
> On Wed, 2008-09-24 at 08:39 +0200, Arnd Bergmann wrote:
> > The ppc_select function was introduced in linux-2.3.48 in order to support
> > code confusing the legacy select() calling convention with the standard one.
> > Even 11 years ago, all correctly built code should not have done this and
> > could have easily been phased out. Nothing that was compiled later should
> > actually try to use the old_select interface, and it would have been broken
> > already on all ppc64 kernels with the syscall emulation layer.
> >
> > This patch brings the 32 bit compat ABI and the native 32 bit ABI for
> > powerpc into a consistent state, by removing support for both the
> > old_select system call number and the handler for it.
>
> .../...
>
> It's me or the patch is whitespaces damaged ?
Please don't apply Arnd's patch. As I said, all we need is this
one-line change in arch/powerpc/include/asm/systbl.h:
-SYSX_SPU(sys_select,ppc32_select,ppc_select)
+SYSX_SPU(sys_select,ppc32_select,sys_select)
Paul.
More information about the Linuxppc-dev
mailing list