[PATCH v2] powerpc/83xx: don't probe broken PCI on mpc837x_mds boards

Anton Vorontsov avorontsov at ru.mvista.com
Sat Oct 4 02:27:09 EST 2008


On Fri, Oct 03, 2008 at 11:14:18AM -0500, Kumar Gala wrote:
>
> On Oct 3, 2008, at 11:08 AM, Anton Vorontsov wrote:
>
>> In the standalone setup the board's CPLD disables the PCI internal
>> arbiter, thus any access to the PCI bus will hang the board.
>>
>> When there is no PCI arbiter on the bus the u-boot adds
>> status = "broken (no arbiter)" property into the PCI controller's
>> node, and so marks the PCI controller as unavailable.
>>
>> Signed-off-by: Anton Vorontsov <avorontsov at ru.mvista.com>
>> ---
>>
>> On Thu, Oct 02, 2008 at 02:48:44PM -0500, Kumar Gala wrote:
>>> Can you add to the commit message something about using the 'status
>>> field in the device tree to determine if the pci controller is
>>> available'
>>
>> Something like this?
>>
>> Thanks,
>
> yes, but should we just have "status = disabled" since that is the  
> effect?

I don't know, should we? For the unavailable/disabled case the status
can be anything but not 'ok' or 'okay' (the only status values for the
available devices). So if we can encode the reason, why not do this?

-- 
Anton Vorontsov
email: cbouatmailru at gmail.com
irc://irc.freenode.net/bd2



More information about the Linuxppc-dev mailing list