USB support on mpc5200 broken

[Matt Sealey]

Jon Smirl wrote:

> 
> Efika has this:
> compatible = "fsl,mpc5200b-ohci","fsl,mpc5200-ohci";

It doesn't :D

My system, running production firmware, says

ohci-bigendian,ohci-be,mpc5200-ohci,mpc5200-usb

This is what we were recommended to use at the time. There is a patch
on www.powerdeveloper.org which tweaks the tree to make it ultra-compliant
with the Linux version of things, which implements every variation. It
also implements a suggested patch which added a "big-endian" property
(not built in to the compatible property, but another property).

I don't see why THAT patch got reverted as it was a great idea that we
all agreed was a great idea.

Linux development around here is getting really schizophrenic. Nobody
is writing these decisions down even as comments in the source code..

> If we really need a big endian flag, should it be an attribute?

Yes.

> Shouldn't the driver already know it is being used on a BE machine?

No; you can have little endian OHCI controllers on big endian machines.
It's a property of the host controller, not the system architecture, just
like PCI is always little endian (except when you have magic in hardware
like Amiga PowerUP cards which endianswap for you :)

-- 
Matt Sealey <matt at genesi-usa.com>
Genesi, Manager, Developer Relations