[PATCH] powerpc: Add sync_*_for_* to dma_ops

Segher Boessenkool segher at kernel.crashing.org
Wed Nov 19 03:57:15 EST 2008


> @@ -286,42 +306,75 @@ static inline void dma_sync_single_for_cpu 
> (struct device *dev,
>  		dma_addr_t dma_handle, size_t size,
>  		enum dma_data_direction direction)
>  {
> -	BUG_ON(direction == DMA_NONE);

Did you intend to remove this here?  It would be nice to test for it
even on platforms where the op is a nop; if there is an equivalent
test in every implementation of the ops, remove it there instead
(that's more source + binary code to remove, always a good thing ;-) )


Segher




More information about the Linuxppc-dev mailing list