[PATCH 14/16 v2] powerpc: expand vs demux ipi actions per message

Paul Mackerras paulus at samba.org
Thu Nov 6 15:42:10 EST 2008


Milton Miller writes:

> With the new generic smp call function helpers, I noticed the code in
> smp_message_recv was a single function call in many cases.  While
> getting the message number from the ipi data is easy, we can reduce
> the path length by a function and data dependent switch by registering
> separate ipi actions for these simple calls.

With this I get:

  CC      arch/powerpc/kernel/smp.o
arch/powerpc/kernel/smp.c: In function 'smp_request_message_ipi':
arch/powerpc/kernel/smp.c:177: error: 'ipi_names' undeclared (first use in this function)
arch/powerpc/kernel/smp.c:177: error: (Each undeclared identifier is reported only once
arch/powerpc/kernel/smp.c:177: error: for each function it appears in.)
make[2]: *** [arch/powerpc/kernel/smp.o] Error 1

I think you need smp_ipi_name rather than ipi_names here:

> +	WARN(err < 0, "unable to request_irq %d for %s (rc %d)\n",
> +		virq, ipi_names[msg], err);

Paul.



More information about the Linuxppc-dev mailing list