[PATCH] Add support for binary includes.

David Gibson david at gibson.dropbear.id.au
Thu May 29 09:58:59 EST 2008


On Tue, May 27, 2008 at 12:59:32PM -0500, Jon Loeliger wrote:
> Kumar Gala wrote:
>>
>> On Feb 25, 2008, at 6:39 PM, David Gibson wrote:
>>
>>> On Wed, Feb 20, 2008 at 01:19:41PM -0600, Scott Wood wrote:
>>>> A property's data can be populated with a file's contents
>>>> as follows:
>>>>
>>>> node {
>>>>     prop = /incbin/("path/to/data");
>>>> };
>>>>
>>>> A subset of a file can be included by passing start and size parameters.
>>>> For example, to include bytes 8 through 23:
>>>>
>>>> node {
>>>>     prop = /incbin/("path/to/data", 8, 16);
>>>> };
>>>>
>>>> As with /include/, non-absolute paths are looked for in the directory
>>>> of the source file that includes them.
>
> That issue was resolved, I believe.
>
>>> Well, while I discuss the syntax with Jon, here's some comments on the
>>> implementation.
>>
>> have we made any progress on the syntax?
>
> My last suggestions garnered a "I like that even less." response,
> so as far as I know, we're still waiting for a good proposal here.

A while back I sent out a spiel explaining more clearly why I didn't
like it, and where I thought we should go with this, but I don't think
anyone noticed it at the time.  I'll resend.

I started working towards a version of this I liked, but was
sidetracked by a combination of my own other work, and the fact that
Jon's been busy meaning there's a rather large lag on merging dtc
patches.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson



More information about the Linuxppc-dev mailing list