[RFC PATCH 1/2] mmc_spi: export probe and remove functions

Anton Vorontsov avorontsov at ru.mvista.com
Mon May 26 22:25:33 EST 2008

On Mon, May 26, 2008 at 02:18:36PM +0200, Pierre Ossman wrote:
> On Fri, 23 May 2008 22:28:34 +0400
> Anton Vorontsov <avorontsov at ru.mvista.com> wrote:
> > ...so we'll able to write bindings for the OpenFirmware without
> > messing with #ifdefs in the driver itself.
> > 
> > Signed-off-by: Anton Vorontsov <avorontsov at ru.mvista.com>
> This looks extremely wrong. Encapsulating probe functions isn't exactly
> in line with the device model and bound to confuse people.
> Your patches doesn't give a complete picture of the OF side of things,
> but can't you solve this by having an init callback somewhere?

Easily, I think this is good (better) idea. Will do.


Anton Vorontsov
email: cbouatmailru at gmail.com

More information about the Linuxppc-dev mailing list