[PATCH] [POWERPC] Improve (in|out)_beXX() asm code

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu May 22 06:41:12 EST 2008

On Wed, 2008-05-21 at 12:44 -0700, Trent Piepho wrote:
> Someone should update memory-barriers.txt, because it doesn't say
> that, and
> all I/O accessors for all the arches, because none of them are.

There have been long discussions about that. The end result was that
being too weakly ordered is just asking for trouble because the majority
of drivers are written & tested on x86 which is in order.

If you look at our accessors, minus that gcc problem you found, the
barriers in there should pretty much guarantee ordering in the cases
that matter, which are basically MMIO read followed by memory accesses
and memory writes followed by MMIO. In fact, MMIO read are fully

> No, it's compiled with a normal kernel build, which includes
> -fno-strict-aliasing

Ok, so there is a very bad bug indeed, we need to fix that.


More information about the Linuxppc-dev mailing list