[PATCH 2/4] [OF] spi_of: add support for dedicated SPI constructors

Grant Likely grant.likely at secretlab.ca
Thu May 22 05:53:01 EST 2008


On Wed, May 21, 2008 at 1:20 PM, Guennadi Liakhovetski
<g.liakhovetski at gmx.de> wrote:
> On Wed, 21 May 2008, Grant Likely wrote:
>
>> If some behaviour is entirely board specific and doesn't have any
>> possibility of being duplicated on other boards, then it makes sense
>> for the code implementing that behaviour to live with the platform
>> code.
>
> Exactly - "entirely board specific" and "doesn't have any possibility of
> being duplicated on other boards."
>
>> > What good is an OF-binding if it doesn't provide complete information?
>>
>> It still increases the amount of common code even if there are rare
>> corner cases that require board specific code.
>
> Right again - _rare_ corner cases. Whereas we are talking about _all_ SPI
> busses, maybe apart from those, where the controller itself switches CSs
> in a well-defined way, and the driver doesn't need any additional
> information to handle this.

Ah, I see where we are crossing our wires.  I was talking about the
case of registering spi devices.  I agree that the spi bus should not
need any additional information.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.



More information about the Linuxppc-dev mailing list