[PATCH 1/7] [POWERPC] sysdev: implement FSL GTM support

Grant Likely grant.likely at secretlab.ca
Wed May 21 00:24:05 EST 2008


On Tue, May 20, 2008 at 7:15 AM, Kumar Gala <galak at kernel.crashing.org> wrote:
>> There (and in the QE GPIO) was an arch_initcall, but based on
>> Grant Likely's review it was removed in favour of platform-specific
>> machine_initcalls.
>>
>> See http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg16469.html
>> There I was trying to argue, but quickly gave up. ;-) I don't have any
>> strong preference for this anyway. I can do either way, just tell which
>> you prefer.
>
> I'd prefer the arch_initcall().  If its the board that is going to do the
> Kconfig select on this that seems sufficient to say do "init" for me w/o an
> explicit call to it.

That's only true if the assumption is that you are not building a
multiplatform kernel.  I'd rather see platform code in control of
registering devices.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.



More information about the Linuxppc-dev mailing list