[PATCH] Sam440ep support

Josh Boyer jwboyer at linux.vnet.ibm.com
Tue May 20 23:34:50 EST 2008


On Tue, 20 May 2008 07:50:28 -0500
Josh Boyer <jwboyer at linux.vnet.ibm.com> wrote:

> On Mon, 19 May 2008 17:20:47 +0200
> Giuseppe Coviello <cjg at cruxppc.org> wrote:
> 
> 
> > +			usb at ef601000 {
> > +				compatible = "ohci-be";
> > +				reg = <ef601000 80>;
> > +				interrupts = <8 4 9 4>;
> > +				interrupt-parent = < &UIC1 >;
> 
> Are you sure the trigger/level settings on those interrupts is
> correct?
> 
> > +			};	
> > +		};
> > +
> > +		PCI0: pci at ec000000 {
> > +			device_type = "pci";
> > +			#interrupt-cells = <1>;
> > +			#size-cells = <2>;
> > +			#address-cells = <3>;
> > +			compatible = "ibm,plb440ep-pci", "ibm,plb-pci";
> > +			primary;
> > +			reg = <0 eec00000 8	/* Config space access */
> > +			       0 eed00000 4	/* IACK */
> > +			       0 eed00000 4	/* Special cycle */
> > +			       0 ef400000 40>;	/* Internal registers */
> > +
> > +			/* Outbound ranges, one memory and one IO,
> > +			 * later cannot be changed. Chip supports a second
> > +			 * IO range but we don't use it for now
> > +			 */
> > +			ranges = <02000000 0 a0000000 0 a0000000 0 20000000
> > +				  01000000 0 00000000 0 e8000000 0 00010000>;
> > +
> > +			/* Inbound 2GB range starting at 0 */
> > +			dma-ranges = <42000000 0 0 0 0 0 80000000>;
> 
> You have no interrupt mapping for the PCI node.  How do you have
> working PCI here?

Also, if these questions result in changes to the DTS, could you please
convert it to a dts-v1 format?  Otherwise I'll have to do it myself and
it's cleaner if it comes in that way.

josh



More information about the Linuxppc-dev mailing list