[PATCH 1/4 V3] booting-without-of for Freescale MSI

Kumar Gala galak at kernel.crashing.org
Tue May 20 16:23:22 EST 2008


On May 16, 2008, at 4:50 AM, Jason Jin wrote:

> Binding document adding for Freescale MSI support.
>
> Signed-off-by: Jason Jin <Jason.jin at freescale.com>
> ---
> Change the compatible name in this V3 version.
>
> Documentation/powerpc/booting-without-of.txt |   41 +++++++++++++++++ 
> ++++++++-
> 1 files changed, 40 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/powerpc/booting-without-of.txt b/ 
> Documentation/powerpc/booting-without-of.txt
> index 1d2a772..789cd5a 100644
> --- a/Documentation/powerpc/booting-without-of.txt
> +++ b/Documentation/powerpc/booting-without-of.txt
> @@ -57,7 +57,10 @@ Table of Contents
>       n) 4xx/Axon EMAC ethernet nodes
>       o) Xilinx IP cores
>       p) Freescale Synchronous Serial Interface
> -	  q) USB EHCI controllers
> +      q) USB EHCI controllers
> +      r) Freescale Display Interface Unit
> +      s) Freescale on board FPGA
> +      t) Freescael MSI interrupt controller
>
>   VII - Marvell Discovery mv64[345]6x System Controller chips
>     1) The /system-controller node
> @@ -2870,6 +2873,42 @@ platforms are moved over to use the flattened- 
> device-tree model.
> 		reg = <0xe8000000 32>;
> 	};
>
> +    t) Freescale MSI interrupt controller
> +
> +    Reguired properities:
> +    - compatible : set as "fsl,mpc8610-msi" for all the cpu which  
> use MPIC,
> +      and set as "fsl,mpc8379-msi" for those use IPIC.

I'd like to see "fsl,ipic-msi" and "fsl,mpic-msi".  If we are going to  
use "chip" names we should use the first in each family that had the  
support so it would be:

"fsl,mpc8641-msi", "fsl,mpc8379-msi", and "fsl,mpc8548-msi".  However  
I've never been a big fan of using the "first" in family like this.   
It becomes difficult later to use this if we have to deal with errata  
on a given device to distinguish things.

So my preference it that we have:

compatible = "fsl,mpc8610-msi", "fsl,mpic-msi";

for the 8610, and for 8572 we'd have:

compatible = "fsl,mpc8572-msi", "fsl,mpic-msi";

so like DMA its "fsl,CHIP-msi", and either "fsl,mpic-msi" or "fsl,ipic- 
msi" depending on the parent type.

- k



More information about the Linuxppc-dev mailing list