[PATCH 0/4] minor fixes for 2.6.26

David Gibson david at gibson.dropbear.id.au
Tue May 20 12:08:56 EST 2008

On Tue, May 20, 2008 at 04:03:47AM +0200, Segher Boessenkool wrote:
>>> I think that adding zImage.* to clean-files is a bad idea, because we
>>> have zImage.lds.S, zImage.coff.lds.S and zImage.ps3.lds.S in
>>> arch/powerpc/boot that we don't want deleted.  It would be OK for
>>> compiling with a separate object directory but would be bad for
>>> compiling in the source directory.
>> Arguably this suggests we should rename either the lds files or the
>> zImages so that we *can* get a pattern to match.
> Not really.  Just define a $(ALL_ZIMAGES) var and use that everywhere.
> I would be pretty upset if "make clean" decided to delete my  
> zImage.backup,
> etc.

That won't work for .gitignore.  Besides it's hard to generate, since
zImage.<allsortsofthings> can be generated based on dts names.

Oh, and variables like that are usually a bad idea for clean rules,
because if new things have just been added/removed from the list, it
will fail to clean up things built before the makefile change was

David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!

More information about the Linuxppc-dev mailing list