ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support)

Takashi Iwai tiwai at suse.de
Thu May 15 15:42:35 EST 2008


At Wed, 14 May 2008 23:01:10 +0200,
Gerhard Pircher wrote:
> 
> 
> -------- Original-Nachricht --------
> > Datum: Wed, 14 May 2008 14:26:53 +0200
> > Von: Takashi Iwai <tiwai at suse.de>
> > An: "Gerhard Pircher" <gerhard_pircher at gmx.net>
> > CC: benh at kernel.crashing.org, galak at kernel.crashing.org, cjg at cruxppc.org, linuxppc-dev at ozlabs.org, alsa-devel at alsa-project.org
> > Betreff: ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support)
> 
> > At Tue, 06 May 2008 11:16:22 +0200,
> > Gerhard Pircher wrote:
> > > 
> > > Naturally I can do some tests, if you or Takashi come up with a new
> > > patch.
> > 
> > OK, here is another patch for testing.  Since I lost my old patch
> > somewhere (and it's not worth to dig the archive), I wrote it up
> > quickly from scratch.  This version should cover both SG and non-SG
> > buffers.  It's against the latest git tree.
> > 
> > The patch adds a hackish verison of dma_mmap_coherent() for some
> > architectures in sound/core/pcm_native.c.  I'm not sure whether this
> > works.  I just tested it on X86.  It'd be appreciated if someone can
> > test this.
> > 
> > Also, this disables HDSPM driver for non-X86/IA64 since the driver has
> > own copy and silence methods that are incompatible with the new
> > SG-buffer data.
> > 
> > 
> > And, yes, I know we need to clean up huge messes in ALSA memory
> > handling routines.  But, let's fix obvious bugs before starting a big
> > rewrite...
> Okay, it seems to work fine so far. No lock-ups or kernel oopses. Tested
> with kernel v2.6.26-rc2 and a Soundblaster 5.1/EMU10k1 device (which was
> not working with the old patch) on my non cache coherent G4 system.

Good to hear.  The next step is to move dma_mmap_coherent() to arch/*
directories...


Takashi



More information about the Linuxppc-dev mailing list