[PATCH 1/6] [WATCHDOG] mpc83xx_wdt: convert to the OF platform driver

Stephen Rothwell sfr at canb.auug.org.au
Wed May 14 09:32:34 EST 2008


Hi Anton,

On Tue, 13 May 2008 18:14:54 +0400 Anton Vorontsov <avorontsov at ru.mvista.com> wrote:
>
> +static struct of_platform_driver mpc83xx_wdt_driver = {
> +	.name		= "mpc83xx_wdt",
> +	.match_table	= mpc83xx_wdt_match,
>  	.probe		= mpc83xx_wdt_probe,
>  	.remove		= __devexit_p(mpc83xx_wdt_remove),
> -	.driver		= {
> -		.name	= "mpc83xx_wdt",
> -		.owner	= THIS_MODULE,
> -	},

You should leave this as it was because the name and owner fields are
being removed from struct of_platform_driver in favour of those embedded in
the .driver.

Maybe I should add a comment to the structure definition.  Or maybe it is
time to actually remove them.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080514/7e2ecc60/attachment.pgp>


More information about the Linuxppc-dev mailing list