[PATCH 4/4] [POWERPC] Xilinx: Framebuffer: Usedcrinfrastructure.

David Gibson david at gibson.dropbear.id.au
Thu May 8 17:01:28 EST 2008


On Wed, May 07, 2008 at 09:46:51PM -0700, Stephen Neuendorffer wrote:
> 
> The problem is that the tft driver currently in mainline assumes
> that the dcr control registers are accessed through mmio, and probes
> for a reg=<> property.  Since the device is actually a dcr device,
> it can be connected via mmio through a bride, or to the native dcr
> bus of the processor.  For the time being, I'd like to generate
> device trees compatible with either mechanism.

Ah, I think I see.  The current driver expects the device to be
represented as if it were an mmio device, not using the standard dcr
notation.  It can get away with this because the DCRs are
memory-mapped, in a way representable by 'ranges'.

> so, the problem is that the tree-parents of the tft node all have
> ranges, and if the dcr-parent of the node is a bridge, then it has a
> reg=<> property, But if the dcr-parent is also a tree-parent, then
> it has to have ranges; and a reg=<> property, which seems very
> strange, and not something I think is a good thing to do.

This I don't follow.

But I don't think it matters.  The representation suggested by Segher,
which has the DCR addressing redundantly described in 'reg' and
'dcr-reg' properties should work for you.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson



More information about the Linuxppc-dev mailing list